Fix save button remaining inactive after upload completes (with passive deposit agreements)

[bbpennel]

Fixes

#6517

Summary

Fixes issue where the "Save" button on the work page is disabled after an upload completes even if all requirements have been met.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

See the linked issue for how to replicate the issue.

Type of change (for release notes)

notes-bugfix

Detailed Description

The issue appears to be that the fileupload('active') value is still "1" at the time that the fileuploadcompleted or fileuploaddone events are fired. It is being retrieved here:
https://github.com/samvera/hyrax/blob/main/app/assets/javascripts/hyrax/save_work/uploaded_files.es6#L16
which is used for deciding if the "Save" button should be disabled. So when the completed event fires, it checks to see if there are any active uploads, and there still are since the plugin doesn't seem to have cleared them yet.

Since 'active' doesn't seem reliable for this purpose, I switched to externally tracking when an upload was started and ended. There is also a 'progress' attribute which records the number of bytes uploaded that might be usable for this, which we could try if that's preferred.

For what its worth, it looks like the jquery.fileupload plugin was archived in May 2023. Some parts also don't seem to be working, like the "Cancel upload" button is disabled for me and doesn't work, plus it doesn't show in progress uploads, the file just eventually appears on the list once the upload finishes. I'm guessing we need to replace it at some point, which might already be in the backlog.

Changes proposed in this pull request:

• Uses an external counter for number of uploads in progress rather than the internal one, since it does not update in time for reevaluating the save button.
• Adds a test to demonstrate the bug and check for passive deposit agreement behavior

@samvera/hyrax-code-reviewers

[dlpierce]

Thanks for tracking this down! Yes, it will need to be replaced. I think some Samvera apps have been investigating alternatives already.