Skip to content

Utilizes Valkyrie patterns for collection_types_controller_spec. #6474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

bwatson78
Copy link
Contributor

Fixes

Fixes spec/controllers/hyrax/admin/collection_types_controller_spec.rb.

Summary

Utilizes Valkyrie patterns for collection_types_controller_spec.

Type of change (for release notes)

  • notes-valkyrie Valkyrie Progress

Changes proposed in this pull request:

  • docker-compose-koppie.yml: bumps up the ports for each chrome port so that dassie and koppie tests can run simultaneously.
  • spec/controllers/hyrax/admin/collection_types_controller_spec.rb: converts collection to Valkyrie object and tests for its existence with a query instead of method.

@samvera/hyrax-code-reviewers

@bwatson78 bwatson78 added valkyrization notes-valkyrie Release Notes: Valkyrie specific labels Nov 27, 2023
@bwatson78 bwatson78 self-assigned this Nov 27, 2023
@bwatson78 bwatson78 force-pushed the updates_collection_types_controller_spec branch from 849501d to ce098b5 Compare November 27, 2023 22:15
@dlpierce dlpierce merged commit 0583697 into main Nov 27, 2023
@dlpierce dlpierce deleted the updates_collection_types_controller_spec branch November 27, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-valkyrie Release Notes: Valkyrie specific valkyrization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants