Make form classes configurable #6395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows applications to provide their own behaviours in subclasses of the default Hyrax form classes (`Hyrax::Forms::AdministrativeSetForm`, `Hyrax::Forms::FileSetForm`, `Hyrax::Forms::PcdmCollectionForm`, `Hyrax::Forms::PcdmObjectForm`) and then tell Hyrax to use those subclasses instead via Hyrax configuration. The situation of `Hyrax::Forms::PcdmCollectionForm` is a bit complicated, since these classes are generated dynamically on‐demand. So the configuration in this case is a Proc rather than a simple class.
marrus-sh
force-pushed
the
form_config
branch
from
b74611f to
568db48
Compare
dlpierce
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows applications to provide their own behaviours in subclasses of the default Hyrax form classes
(
Hyrax::Forms::AdministrativeSetForm,Hyrax::Forms::FileSetForm,Hyrax::Forms::PcdmCollectionForm,Hyrax::Forms::PcdmObjectForm) and then tell Hyrax to use those subclasses instead via Hyrax configuration.The situation of
Hyrax::Forms::PcdmCollectionFormis a bit complicated, since these classes are generated dynamically on‐demand. So the configuration in this case is a Proc rather than a simple class.