use locally defined conf to map mime_types derivative methods #6238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 28, 2023 15:12
Adds `Hyrax.config.derivative_mime_type_mappings` to provide configuration mapping mime_types to derivative handling behavior. This used to be triggered based on `FileSet` class methods, but Hyrax has never had direct control over `FileSet` (usually an ActiveFedora model). new Valkyrie applications normally won't want to define a model class named this. currently, they are forced to because `FileSet` is referenced in various places (including here!) in the codebase. we probably don't want to ask them to hang configuration off this, so provide a local configuration option and default to the class defenitions for backward compatibility.
no-reply
added
notes-minor
tpendragon
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Hyrax.config.derivative_mime_type_mappingsto provide configurationmapping mime_types to derivative handling behavior. This used to be triggered
based on
FileSetclass methods, but Hyrax has never had direct control overFileSet(usually an ActiveFedora model).new Valkyrie applications normally won't want to define a model class named
this. currently, they are forced to because
FileSetis referenced in variousplaces (including here!) in the codebase. we probably don't want to ask them to
hang configuration off this, so provide a local configuration option and default
to the class defenitions for backward compatibility.
Changes proposed in this pull request:
Hyrax.config.derivative_mime_type_mappings, which can be overridden as an alternative to redefiningFileSet.image_mime_typesand similar methods.@samvera/hyrax-code-reviewers