remove deprecated argument from CollectionBrandingInfo#delete #6231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunn
previously approved these changes
Aug 28, 2023
|
We think that this is just a test error, maybe there's something wrong with the |
dlpierce
force-pushed
the
banner-info-deprecation
branch
from
87c04bd to
bfe5096
Compare
dlpierce
reviewed
Sep 8, 2023
Comment on lines
+57
to
+64
| it "removes banner file" do | ||
| expect { banner_info.delete }.to change { | ||
| begin | ||
| storage_adapter.find_by(id: banner_info.local_path) | ||
| rescue Valkyrie::StorageAdapter::FileNotFound | ||
| 'Raised FileNotFound' # Convert the raised error so change can detect it | ||
| end | ||
| }.from(be_a(Valkyrie::StorageAdapter::File)).to(eq 'Raised FileNotFound') |
There was a problem hiding this comment.
I couldn't find a way to make the change matcher play nicely with raised errors, so instead I'm converting it to a string.
tpendragon
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@samvera/hyrax-code-reviewers