Skip to content

Stop testing middle ruby versions #6105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Stop testing middle ruby versions #6105

merged 4 commits into from
Jul 25, 2023

Conversation

dlpierce
Copy link
Member

@dlpierce dlpierce commented Jul 3, 2023

Only perform tests on our min/max ruby versions. These are not required checks already.
Also updates some versions in circle.

@samvera/hyrax-code-reviewers

Only perform tests on our min/max ruby versions.
Also updates some versions in circle
@dlpierce dlpierce added the notes-minor Release Notes: Non-breaking features label Jul 3, 2023
Copy link
Member

@orangewolf orangewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the current failures are flaky specs

It now looks like there might be real failures.

alishaevn added a commit that referenced this pull request Jul 25, 2023
…ired.

this work was originally done by @dlpierce in #6105. that pr however also updates the circle ci versions and is failing. I expect those are legitimate failures, but do not want to hold up removing these testing versions in the meantime. removing these versions will allow our spec suite to move faster and provide a shorter pathway to a green spec suite.

co-authored-by: daniel pierce <dlpierce@indiana.edu>
@alishaevn alishaevn merged commit 9339f23 into main Jul 25, 2023
@alishaevn alishaevn deleted the ci-versions branch July 25, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-minor Release Notes: Non-breaking features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants