🎁 1019 batch email notifications #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fleshes out the `BatchEmailNotificationJob` and adds a preview for the email that will be sent.
This commit adds the new job to the queue whenever a new tenant is created. Also adding a method to the `User` model to mark all undelivered emails as delivered when their batch email frequency is changed to 'off'.
ShanaLMoore
changed the title
ShanaLMoore
commented
May 1, 2024
The prior default value of `off` appears to be a reserved term and did not work for i18n translations.
laritakr
force-pushed
the
i1019-batch-email-notifications
branch
from
41e4780 to
ce55983
Compare
- Show email frequency on user profile - Add selection list to edit profile menu to update frequency - Add appropriate translations to en.yml Ref: notch8/palni-palci#1022
laritakr
force-pushed
the
i1019-batch-email-notifications
branch
from
ce55983 to
0861258
Compare
|
Requires translations to run. |
added 4 commits
May 2, 2024 08:38
This commit will ensure the correct bootstrap class is on the batch email frequency select box. It will also use the font awesome calendar icon for the label.
Since it seems 'off' was protected, we switched to 'never' instead, this commit will clean up any other places where it was set to 'off'.
This commit will add a callback for `Mailboxer::Receipt` to mark the receipt as delivered if the user set their batch_email_frequency to 'never'.
This commit will add a few specs and also redo the logic for the batch email notification send frequency. We needed a migration to the users model to track when the last email was sent to check if it's time to send another one based on their batch_email_frequency setting.
kirkkwang
force-pushed
the
i1019-batch-email-notifications
branch
from
fa8a90b to
7c0c652
Compare
added 3 commits
May 3, 2024 08:48
This commit runs the Google translations for i18n files.
kirkkwang
changed the title
laritakr
previously approved these changes
May 6, 2024
| <body> | ||
| <h2>Hello, <%= @user.name %></h2> | ||
| <p>You have the following notifications:</p> | ||
| <p>Click <a href="<%= @url %>">here</a> to view them in Hyku.</p> |
There was a problem hiding this comment.
I'm wondering if we should use the application &/or tenant name rather than "Hyku"? Not a big deal, but many of the users may not know what "Hyku" is. If the email is too generic, wouldn't they possibly just assume it's spam? Including the actual site name, a possible site logo, etc would seem more clear.
Additionally, I can see a future request might be to use i18n for the email text... just something to consider.
|
We discussed we will replace HYKU with the account settings, in the email. Maybe institution name? Email language support will be out of scope for this round. Have the client create another ticket for this request. |
This commit will add the Site's application name into the email subject as well as the body.
laritakr
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story
Users can get the notifications in the form of an email digest set to daily, weekly, or monthly frequencies.
Refs
Expected Behavior Before Changes
Users only get notifications that they would check in the admin dashboard (top right area).
Expected Behavior After Changes
Users can choose a daily, weekly, or monthly email digest of notifications sent to their registered email.
Screenshots / Video
Notes