Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Fix stub methods to pass tests #2087

Merged
merged 1 commit into from
Dec 20, 2023
Merged

🤖 Fix stub methods to pass tests #2087

merged 1 commit into from
Dec 20, 2023

Commits on Dec 20, 2023

  1. 🤖 Fix stub methods to pass tests 

    These tests weren't verifying that we could reach Redis; they were
testing the interface of the `RedisEndpoint#ping` by mocking the
instance.

This commit changes the mocking by avoiding a call to
`Hyrax::RedisEventStore.instance` which was raising a Redis connection
error.

Again, this test is not is redis connecting but "assume we are trying to
connect to redis now demonstrate ping."
    @jeremyf
    jeremyf committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    73359b6 View commit details
    Browse the repository at this point in the history