Update hyrax double combo #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 19, 2023
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) | ||
| }) |
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) |
| var allColorInputs = $("input[name*='color']") | ||
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) |
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var allColorInputs = $("input[name*='color']") |
| }) | ||
|
|
||
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() |
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") | ||
|
|
||
| input.val(input.data('default-value')) | ||
| }) |
| var defaultTarget = $(e.target).data('default-target') | ||
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") | ||
|
|
||
| input.val(input.data('default-value')) |
| e.preventDefault() | ||
|
|
||
| var defaultTarget = $(e.target).data('default-target') | ||
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") |
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var defaultTarget = $(e.target).data('default-target') |
| @@ -0,0 +1,20 @@ | |||
| $(document).on('turbolinks:load', function() { | |||
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | |||
| e.preventDefault() | |||
houndci-bot
reviewed
Dec 19, 2023
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) | ||
| }) |
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) |
| var allColorInputs = $("input[name*='color']") | ||
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) |
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var allColorInputs = $("input[name*='color']") |
| }) | ||
|
|
||
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() |
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") | ||
|
|
||
| input.val(input.data('default-value')) | ||
| }) |
| var defaultTarget = $(e.target).data('default-target') | ||
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") | ||
|
|
||
| input.val(input.data('default-value')) |
| e.preventDefault() | ||
|
|
||
| var defaultTarget = $(e.target).data('default-target') | ||
| var input = $("input[name='admin_appearance["+ defaultTarget +"]']") |
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var defaultTarget = $(e.target).data('default-target') |
| @@ -0,0 +1,20 @@ | |||
| $(document).on('turbolinks:load', function() { | |||
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | |||
| e.preventDefault() | |||
houndci-bot
reviewed
Dec 19, 2023
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) | ||
| }) |
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) |
| var allColorInputs = $("input[name*='color']") | ||
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) |
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var allColorInputs = $("input[name*='color']") |
| }) | ||
|
|
||
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() |
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var defaultTarget = $(e.target).data('default-target') |
| @@ -0,0 +1,20 @@ | |||
| $(document).on('turbolinks:load', function() { | |||
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | |||
| e.preventDefault() | |||
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); | ||
| var x_ticks = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| //flot loaded? And canvas element supported. | ||
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
houndci-bot
reviewed
Dec 19, 2023
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) | ||
| }) |
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) |
| var allColorInputs = $("input[name*='color']") | ||
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) |
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var allColorInputs = $("input[name*='color']") |
| }) | ||
|
|
||
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() |
| @@ -0,0 +1,20 @@ | |||
| $(document).on('turbolinks:load', function() { | |||
| $('div.defaultable-colors a.restore-default-color').click(function(e) { | |||
| e.preventDefault() | |||
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); | ||
| var x_ticks = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| //flot loaded? And canvas element supported. | ||
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| }; | ||
|
|
||
| global.BlacklightRangeLimit = BlacklightRangeLimit; | ||
| }(this); |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
houndci-bot
reviewed
Dec 19, 2023
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) | ||
| }) |
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) | ||
| }) |
| var allColorInputs = $("input[name*='color']") | ||
|
|
||
| allColorInputs.each(function() { | ||
| $(this).val($(this).data('default-value')) |
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() | ||
|
|
||
| var allColorInputs = $("input[name*='color']") |
| }) | ||
|
|
||
| $('.panel-footer a.restore-all-default-colors').click(function(e) { | ||
| e.preventDefault() |
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); | ||
| var pointer_lookup = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| //flot loaded? And canvas element supported. | ||
| if (domDependenciesMet()) { | ||
| // Grab the data from the ul div | ||
| var series_data = new Array(); |
There was a problem hiding this comment.
The array literal notation [] is preferable.
| }; | ||
|
|
||
| global.BlacklightRangeLimit = BlacklightRangeLimit; | ||
| }(this); |
There was a problem hiding this comment.
Expected an assignment or function call and instead saw an expression.
| max = BlacklightRangeLimit.parseNum($(range_element).find(".max").first().text()); | ||
| } | ||
|
|
||
| return [min, max] |
|
|
||
|
|
||
|
|
||
| var min = max = BlacklightRangeLimit.parseNum(current_limit.find(".single").text()) |
There was a problem hiding this comment.
Missing semicolon.
You might be leaking a variable (max) here.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in most recent changes from double_combo branch.