add-clause-to-account-settings-for-google_analytics_id #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g environment, if the google_analytics_id was not available we would receive a routing error for the partials in the admin dashboard. I also saw errors in my local logs but I didn't discover them till I was looking closely. When account_settings.rb would use the method, reload_library_config, it didn't matter if google_analytics_id.present? or not, the application would need to look in the analytics.rb file which is commented out, which throws an error and doesnt allow us the ability to deploy in a staging environment without Google analytics being setup
orangewolf
approved these changes
Nov 18, 2022
orangewolf
deleted the
add-clause-to-account-settings-for-google_analytics_id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check for the presence of the google_analytics_id. In a staging environment, if the google_analytics_id was not available we would receive a routing error for the partials in the admin dashboard locally. I also saw errors in my local logs when account_settings.rb would use the method,
reload_library_config, on the step ofconfig.google_analytics_id = google_analytics_idit didn't matter if google_analytics_id.present? or not, the application would need to look in the analytics.yml file which is commented out, and throws an error. In a staging or production environment it gets caught in the hyrax step of the web deployment process.Error:
Logs are attached from hyku-demo's staging instance with an error preventing the hyrax stage of the web container during the deployment process. This error is preventing the deployment from completing.
hyku-demo-hyrax-577d7b66b9-f265x_hyrax.log
I also am not quick enough to get the file updated live on the server during the deployment process, I only have 30~ish seconds until the pod disconnects. But did test it locally to ensure the errors didn't show in the logs.