Fix shared search links #1823
Merged
Fix shared search links #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: * homepage `View All Collections` button * catalog Collection title links * catalog Work thumbnail links Activates: * catalog Collection thumbnail links
ShanaLMoore
reviewed
Jul 12, 2022
|
@laritakr Overall it looks good. Nice work! Please check the description. I updated it with screenshots which hopefully reflects everything you did. I left a minor comment about using a decorator pattern to override files per Rob's discussion about preferences the other day, although I totally acknowledge that class or module eval works as well. |
ShanaLMoore
previously approved these changes
Jul 13, 2022
ShanaLMoore
reviewed
Jul 13, 2022
ShanaLMoore
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes utk issue 63 - homepage no longer has collection list
Fixes utk issue 69 - Find all collections button works correctly
Changes:
Fixes:
View All CollectionsbuttonActivates:
SCREENSHOTS/DEMO
This search tenant will return results from 2 tenants named Alpha and Beta. Clicking the View All Collections button should not error:
The appropriate tenant name should be in the domain, when hovering over a returned item. Clicking into them should not cause an error:
Blank search to return all works and collections:
To test:
Related tickets - these are known bugs to be fixed separately:
@samvera/hyku-code-reviewers