Merge pull request #2085 from samvera/hyrax-5-upgrade-fix-collection-…

…type-feature

🤖 Fix spec/features/collection_type_spec.rb

spec/features/collection_type_spec.rb

@@ -376,19 +376,15 @@
 
     context 'when collections exist of this type' do
       before do
-        create(
-          :public_collection_lw,
-          user: build(:user),
-          collection_type_gid: exhibit_collection_type.gid
-        )
+        FactoryBot.create(:public_collection_lw, user: build(:user), collection_type: exhibit_collection_type)
 
         exhibit_collection_type
         login_as admin_user
         visit "/admin/collection_types/#{exhibit_collection_type.id}/edit"
       end
 
       it 'all settings are disabled', :js do
-        expect(exhibit_collection_type.collections?).to be true
+        expect(exhibit_collection_type.collections.any?).to be true
 
         click_link('Settings', href: '#settings')
 
@@ -446,7 +442,7 @@
         create(
           :public_collection_lw,
           user: admin_user,
-          collection_type_gid: not_empty_collection_type.gid
+          collection_type: not_empty_collection_type
         )
       end
       # OVERRIDE: split deny_delete_modal_text into two variables since the test was failing over the newline character
@@ -474,7 +470,7 @@
         end
 
         # forwards to Dashboard -> Collections -> All Collections
-        within('li.active') do
+        within('.nav-tabs li.nav-item') do
           expect(page).to have_link('All Collections')
         end
 
@@ -492,7 +488,6 @@
   end
 
   # OVERRIDE: new (non-hyrax) test cases below
-
   describe 'default collection type participants', ci: 'skip' do
     let(:title) { 'Title Test' }