Skip to content

Commit

Permalink
🧹 Rearrange order of filter chain
Browse files Browse the repository at this point in the history
This is not tested in the UI, but the
`show_works_or_works_that_contain_files` remains after the troublesome
advanced query filters.
  • Loading branch information
jeremyf committed Dec 21, 2023
1 parent dd0d99b commit 1929072
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions spec/search_builders/adv_search_builder_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,12 @@
#
# When we had those duplicates, the :add_advanced_parse_q_to_solr obliterated the join logic
# for files.
#
# Is the order immutable? No. But it does highlight that you must consider what the changes
# might mean and double check that join logic on files.
%i[
default_solr_parameters
add_search_field_default_parameters
add_query_to_solr
add_facet_fq_to_solr
add_facetting_to_solr
Expand All @@ -35,12 +39,14 @@
add_sorting_to_solr
add_group_config_to_solr
add_facet_paging_to_solr
add_adv_search_clauses
add_additional_filters
add_range_limit_params
add_advanced_parse_q_to_solr
add_advanced_search_to_solr
add_access_controls_to_solr_params
filter_models
only_active_works
add_advanced_parse_q_to_solr
add_advanced_search_to_solr
add_access_controls_to_solr_params
show_works_or_works_that_contain_files
show_only_active_records
Expand Down

0 comments on commit 1929072

Please sign in to comment.