Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure autoplay of next section when selecting inaccesible item #569

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Ensure autoplay of next section when selecting inaccesible item #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/components/StructuredNavigation/StructuredNavigation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const StructuredNavigation = () => {
const playerDispatch = usePlayerDispatch();

const { clickedUrl, isClicked, isPlaying, player } = usePlayerState();
const { canvasDuration, canvasIndex, hasMultiItems, targets, manifest, playlist, canvasIsEmpty, canvasSegments } =
const { canvasDuration, canvasIndex, hasMultiItems, targets, manifest, playlist, canvasIsEmpty, canvasSegments, autoAdvance } =
useManifestState();

const { showBoundary } = useErrorBoundary();
Expand Down Expand Up @@ -128,7 +128,16 @@ const StructuredNavigation = () => {
} else if (canvasIsEmptyRef.current) {
// Reset isClicked in state for
// inaccessible items (empty canvases)
playerDispatch({ type: 'resetClick' });
playerDispatch({
type: 'resetClick',
});
// Ensure autoplay from inaccessible items in playlists
if (playlist) {
playerDispatch({
isPlaying: autoAdvance,
type: 'setPlayingStatus',
})
}
}
}
}, [isClicked, player]);
Expand Down