-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust content search when switching between transcripts #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a little testing and search feels improved. I ran into a couple inconsistencies:
- highlighting words within other words (e.g.
you
andyour
) - phrase searching correctly highlights but hit count is 0 (e.g.
feeling better
)
Dananji
force-pushed
the
refine-content-search
branch
from
June 26, 2024 18:00
d2a7178
to
5827fd3
Compare
…t search factory for matching
Dananji
force-pushed
the
refine-content-search
branch
from
June 26, 2024 18:08
5827fd3
to
3e24639
Compare
4 tasks
…bal matching for JS search
Dananji
force-pushed
the
refine-content-search
branch
from
June 27, 2024 14:22
08ae4d3
to
0eb40ec
Compare
masaball
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell this looks good.
Co-authored-by: Mason Ballengee <68433277+masaball@users.noreply.github.com>
Dananji
force-pushed
the
refine-content-search
branch
from
June 27, 2024 15:51
5a1a27f
to
0a96e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refinements to feature added in #502
This PR includes the following refinements to content search: