Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marker component #245

Merged
merged 8 commits into from
Oct 2, 2023
Merged

Add marker component #245

merged 8 commits into from
Oct 2, 2023

Conversation

cjcolvar
Copy link
Member

Includes rebase of annotation-service-markers branch.

Dananji and others added 6 commits September 20, 2023 09:58
…rkers display

Co-authored-by: Chris Colvard <cjcolvar@iu.edu>
Co-authored-by: Mason Ballengee <masaball@iu.edu>
Co-authored-by: Jon Cameron <joncamer@iu.edu>
Co-authored-by: Mason Ballengee <masaball@iu.edu>
Co-authored-by: Dananji Withana <dwithana@iu.edu>
Co-authored-by: Mason Ballengee <masaball@iu.edu>
@Dananji
Copy link
Collaborator

Dananji commented Sep 28, 2023

With form not collapsed;
image

Create marker form, time is auto filled from the current playhead time in the player when Add new marker button is clicked;
image

Timestamp validation;
image

Feedback upon failed submission;
image

@Dananji Dananji marked this pull request as ready for review September 28, 2023 13:26
Dananji and others added 2 commits September 29, 2023 16:06
Co-authored-by: Mason Ballengee <masaball@iu.edu>
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
@cjcolvar cjcolvar changed the title [WIP] Add marker Add marker component Oct 2, 2023
@Dananji Dananji merged commit 1f44ea6 into main Oct 2, 2023
2 checks passed
@Dananji Dananji deleted the add-marker branch October 2, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants