Supplemental files #206
Merged
Supplemental files #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great 💯 I had only one comment on the SupplementalFiles component's conditional rendering part. |
Dananji
reviewed
Jul 17, 2023
Co-authored-by: Chris Colvard <cjcolvar@indiana.edu> Co-authored-by: Mason Ballengee <masaball@iu.edu> Co-authored-by: Jon Cameron <joncamer@iu.edu>
List all supplemental files (renderings) with a header for manifest level files and the associated canvas label for any canvas level files Updated demo to put files in a tab TODO: Write tests, fix CSS (padding/margin in tab), refactor canvas label fetching code? Co-authored-by: Dananji Withana <dwithana@iu.edu>
…nd clean up layout
Dananji
force-pushed
the
supplemental-files
branch
from
a80a27c
to
7ddca07
Compare
Dananji
force-pushed
the
supplemental-files
branch
from
7ddca07
to
dfbd016
Compare
|
I added new tests and rebased the branch from |
cjcolvar
commented
Jul 19, 2023
Dananji
force-pushed
the
supplemental-files
branch
from
0ef4a9a
to
c380707
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add component to show supplemental files (renderings) from manifest and canvas level.
TODO: Write tests, fix CSS (padding/margin in tab), refactor canvas label fetching code?