Discord message #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift/send-message/message-types/discord/Sources/send-discord.swift
Outdated
Show resolved
Hide resolved
|
|
||
| //The response contains all users with the queried username as a substring in their username or nickname. | ||
| //The below loop makes sure the currect user is messaged. | ||
| for user in jsonResponse{ |
There was a problem hiding this comment.
lets encapsulate this in it's own function and unit test it
swift/send-message/message-types/discord/Sources/send-discord.swift
Outdated
Show resolved
Hide resolved
swift/send-message/message-types/discord/Sources/send-discord.swift
Outdated
Show resolved
Hide resolved
swift/send-message/message-types/discord/Sources/send-discord.swift
Outdated
Show resolved
Hide resolved
zachspang
force-pushed
the
discord-message
branch
from
604d4fb
to
1012a50
Compare
zachspang
force-pushed
the
discord-message
branch
from
1012a50
to
0cee868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.