Skip to content

Conversation

@beeman
Copy link
Contributor

@beeman beeman commented Nov 25, 2025

Description

Replaces the usage of the plain function wrapped in a try/catch with the hook introduced in #587


Important

Refactor to use useHandleCopyText hook for text copy operations in portfolio-ui-account-sheet-receive.tsx and use-shell-command-group-suggestions.tsx.

  • Refactor:
    • Replace handleCopyText with useHandleCopyText hook in portfolio-ui-account-sheet-receive.tsx and use-shell-command-group-suggestions.tsx.
    • Simplifies copy operation by removing try/catch blocks and directly using handleCopy() from the hook.
  • Behavior:
    • In portfolio-ui-account-sheet-receive.tsx, handleCopy now uses account.publicKey with success and error toasts.
    • In use-shell-command-group-suggestions.tsx, handleCopy uses publicKey with localized success and error messages.

This description was created by Ellipsis for f3439d6. You can customize this summary. It will automatically update as commits are pushed.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2025

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
samui-wallet-web ae76f39 Commit Preview URL

Branch Preview URL
Nov 25 2025, 08:33 AM

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to f3439d6 in 56 seconds. Click for details.
  • Reviewed 79 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/portfolio/src/ui/portfolio-ui-account-sheet-receive.tsx:27
  • Draft comment:
    Consider passing handleCopy directly to the onClick prop (i.e. onClick={handleCopy}) instead of wrapping it in an arrow function, for cleaner and more concise code.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. packages/shell/src/ui/use-shell-command-group-suggestions.tsx:17
  • Draft comment:
    Consider assigning handleCopy directly as the handler (i.e. handler: handleCopy) rather than wrapping it in an arrow function.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_adcgvicqyAfCtzQ7

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@beeman beeman force-pushed the beeman/use-handle-copy-test branch from f3439d6 to ae76f39 Compare November 25, 2025 08:31
@tobeycodes tobeycodes merged commit 38ebd92 into main Nov 26, 2025
15 checks passed
@tobeycodes tobeycodes deleted the beeman/use-handle-copy-test branch November 26, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants