Trying to do my part in making the world a better place 🌎✌️☮️ #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
benlangfeld
suggested changes
Oct 27, 2021
| else if(number === 375002 || number === "375002" || number === "three hundred seventy-five thousand two" || number === "Three Hundred Seventy-Five Thousand Two" || number === "THREE HUNDRED SEVENTY-FIVE THOUSAND TWO") return true; | ||
| else if(number === 375003 || number === "375003" || number === "three hundred seventy-five thousand three" || number === "Three Hundred Seventy-Five Thousand Three || number === "THREE HUNDRED SEVENTY-FIVE THOUSAND THREE") return false; | ||
| else if(number === 375004 || number === "375004" || number === "three hundred seventy-five thousand four" || number === "Three Hundred Seventy-Five Thousand Four" || number === "THREE HUNDRED SEVENTY-FIVE THOUSAND FOUR") return true; | ||
| else if(number === 375005 || number === "375005" || number === "three hundred seventy-five thousand five" || number === "Three Hundred Seventy-Five Thousand Five" || number === "THREE HUNDRED SEVENTY-FIVE THOUSAND FIVE") return false; |
There was a problem hiding this comment.
I'd like to report a bug. The number 375006 is very important to my application and its incompatibility with this version of the library is a totally obvious bug that the maintainers should fix immediately because if they don't I'll have a hissy fit about how this isn't good service and that I'll take my application dependencies elsewhere.
What release will the fix be in?
There was a problem hiding this comment.
@benlangfeld I've added the number 375006. Apologies for that oversight.
There was a problem hiding this comment.
@eabousaif I think this gem is done now. Definitely shouldn't receive further commits or releases because I don't want to have to upgrade my app all the time. 🤡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds numbers 375001 to 375005 to check if they are even