Detect same-second file edits when polling - #388
Open
DSeaStar wants to merge 1 commit into
Open
Conversation
notify's PollWatcher only compares mtime at second resolution, so force_polling missed content changes that landed in the same second. Hash file contents as well so those edits still produce events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #319.
notify::PollWatcherkeeps mtime as whole seconds, soforce_polling=Truemissed content changes that landed in the same second as the previous scan. Enablecompare_contentson the poll watcher so those edits still produce a modified event.Added a regression test that rewrites a file and then freezes its mtime, which used to be invisible to polling.