uprev notify to 5.0.0-pre.16

[samuelcolvin]

ref notify-rs/notify#249 (comment)

[0xpr03]

Add notify::Config as Config::default() to watcher initialization.
Also PollWatcher now has the default interface, as all watchers now take a Config (with only the pollwatcher config settings currently), thus enabling one config for all possible backends.

(And if you want the debouncer, it is the only way to enable some features on init.)

[codecov]

Codecov Report

Merging #182 (15fa415) into main (6636d3d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #182   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          385       385           
  Branches        81        81           
=========================================
  Hits           385       385           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6636d3d...15fa415. Read the comment docs.

[samuelcolvin]

Add notify::Config as Config::default() to watcher initialization. Also PollWatcher now has the default interface, as all watchers now take a Config (with only the pollwatcher config settings currently), thus enabling one config for all possible backends.

(And if you want the debouncer, as the only way to enable some features on init.)

Thanks, done I think.

Config::new(delay, compare_contents) would be much more use friendly than Config::default().with_poll_interval(delay), would you consider adding new()?

[0xpr03]

The idea was to allow extending this in the future. Your idea would break semver (require a major release) if I'd add more settings into the new() call.
Edit: Otherwise I could have just made one struct with pub fields.

[samuelcolvin]

Ye I see that, rust's lack of default/optional/keyword arguments bites again.

[0xpr03]

You can actually do

Config {
delay: 1,
..default()
}

But that's cumbersome and doesn't require (AFAIK) you to actually do the default call, so would break semver. (I've got the feeling I'm missing some better option.)

[samuelcolvin]

You can actually do

Yes, I thought about exactly that, but if you do

let config = Config {
    poll_interval: delay,
    compare_contents: whatever,
    ...Default::default(),
};

(adding the ...Default::default() so new fields don't break the code)

I think clippy would complain that ...Default::default() can be removed.