BUG FIX: Use Path.relative_to() for Python 3.8 compatibility#150
BUG FIX: Use Path.relative_to() for Python 3.8 compatibility#150samuelcolvin merged 1 commit intosamuelcolvin:mainfrom johnslavik:path-relcheck-fix
Path.relative_to() for Python 3.8 compatibility#150Conversation
Path.relative_to() for Python 3.8 compatibilityPath.relative_to() for Python 3.8 compatibility
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 8 8
Lines 729 729
Branches 111 111
=======================================
Hits 702 702
Misses 21 21
Partials 6 6 Continue to review full report in Codecov by Sentry.
|
|
I believe the CI pipeline should be configured to lint on the minimal supported Python version to ensure backward compatibility, not on 3.10 as it is configured now. |
samuelcolvin
left a comment
There was a problem hiding this comment.
otherwise LGTM, sorry for the slow review.
Shall I drop Python 3.7 support in a separate PR? @samuelcolvin |
|
I'm happy to drop 3.7 support. |
|
Thanks so much. |
|
You're welcome! devtools are awesome! 🚀 |
|
Thanks so much. |
.is_relative_tois 3.9+. It causedpython -m devtools installto fail in Python 3.8.https://docs.python.org/3/library/pathlib.html#pathlib.PurePath.is_relative_to