This repository was archived by the owner on Sep 4, 2019. It is now read-only.
Fix JSON.jl _print deprecation #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Hi @TotalVerb thanks for the PR. Just FYI there is not currently an active maintainer for Bokeh.jl at the moment. If you are interested in Julia and Bokeh integration, and have the time and interest to contribute on a bigger scale the core Bokeh team would certainly be interested in helping you update Bokeh.jl to current releases. There is a world of difference between Bokeh 0.3 and current ~0.12.2 that is not available to Julia users right now. |
Contributor
|
@bryevdv @TotalVerb I'm happy to review pull requests here, but don't have time to be the full maintainer and bring the project fully up to date with bokeh.js. |
TotalVerb
changed the title
Contributor
Author
|
Should be good to merge now. |
Contributor
|
Thank you, will do! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON.lower has been introduced to replace JSON._print, whose overloads will be deprecated in JSON v0.7.0, and will be removed in the future. See JuliaLang/METADATA.jl#5988 for the PR introducing the v0.7.0 tag. I would recommend not merging until the tag is actually merged (it's temporarily stalled because of plans to drop v0.3 support.)