expose connection session id #81
Conversation
|
It is same as what i did. |
|
Thanks for the patch, unfortunately this introduces a data race. Need to atomically set/get the session ID for it to be safe. There's only a few places it's used though so should be pretty straightforward. |
* upstream/master: Do not discard session on connection drop Fix the server reported in the connecting event Restore watches on authentication success Better logging of connection state transitions Derive network timeouts from negotiated session timeout Fix typo
|
@samuel thanks for pointing that out, just updated with atomic stores |
|
This is something I could use in my current project. In some cases it's important to know your session ID, so that you can determine if you are the owner of a znode ( Also, is there a known issue with session timeout detection? I set my session timeout to 1s and its not being honored. |
|
@talbright I'm not sure, but I think the session timeout issue is an encoding problem. it is something i've seen as well (#82) |
|
It may even be worse than that (session didn't expire after two ticks), but I'm still waiting for some time to investigate it further. I left my go-zookeeper client running, shut down my zk server, and brought it up minutes later. My session still didn't expire. Not sure yet though if that's a client issue, a server setting problem, or some conceptual thing I'm missing. |
|
Can this be merged please. |
|
Looks good. Thanks! |
No description provided.