This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
Never reset Conn.xid (fixes #5) #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @samuel, what do you think about this PR? |
|
Looks good. thanks for the patch |
samuel
added a commit
that referenced
this pull request
Aug 17, 2015
Never reset Conn.xid (fixes #5)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was discovered that several requests can be assigned the same
xid. The reason for that is that theConn.autheticate()function can resetConn.xidto 0. A solution that this PR suggests is to never reset theConn.xid, it only needs to be unique for every request after all.