This repository was archived by the owner on Jul 21, 2021. It is now read-only.
add a Logger interface and setter for the logging Printf calls #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding this Logger interface, and by fulfilling the interface with a function that has no body, you can silence the log messages from the *zk.Conn instance. The `Connect()` and `ConnectWithDialer()` functions both set the logger up by default to log to `Stderr`. Fixes samuel#60.
|
Thanks for putting together this patch. |
| @@ -143,6 +150,9 @@ func ConnectWithDialer(servers []string, sessionTimeout time.Duration, dialer Di | |||
| if dialer == nil { | |||
| dialer = net.DialTimeout | |||
| } | |||
|
|
|||
| newLogger := log.New(os.Stderr, "", log.LstdFlags) | |||
There was a problem hiding this comment.
I think it would be best to use the default logger so that if someone has already used log.SetOutput then it'll work as expected (as before).
type defaultLogger struct{}
func (defaultLogger) Printf(format string, v ...interface{}) {
log.Printf(format, v...)
}
newLogger := defaultLogger{}
There was a problem hiding this comment.
Absolutely. I should have gone with that pattern in the first place. I should go further and export the type. That way, someone could fall back to the original logger, if needed, without needing to dive in to the source to see how we create it.
* remove custom formatting in one of the `Printf()` statements to add a newline character at the end * changed how the default logger is instantiated -- new defaultLogger type, and an exported variable that is an instance of it
theckman
force-pushed
the
add_logging_interface
branch
from
ecb8e8a to
24aa123
Compare
|
Okay, I think I properly addressed your feedback. Please let me know if there's anything else that needs done. |
|
Looks great. Thanks! |
samuel
added a commit
that referenced
this pull request
Jun 5, 2015
add a Logger interface and setter for the logging Printf calls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding this Logger interface, and by fulfilling the interface with a function that has no body, you can silence the log messages from the *zk.Conn instance. The
Connect()andConnectWithDialer()functions both set the logger up by default to log toStderr.Fixes #60.