This repository was archived by the owner on Jul 21, 2021. It is now read-only.
[Fix] Conn.Close stops all goroutines if we haven't connencted yet #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without that patch Conn.Close cannot interrupt Conn.connect. So it's impossible to dispose two goroutines related to a connection, if the connection hasn't been established yet. Signed-off-by: Anton Tiurin <noxiouz@yandex.ru>
noxiouz
changed the title
|
Good catch and patch looks great. Thanks! |
samuel
added a commit
that referenced
this pull request
Mar 28, 2015
[Fix] Conn.Close stops all goroutines if we haven't connencted yet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without that patch Conn.Close cannot interrupt Conn.connect.
So it's impossible to dispose two goroutines related to a connection,
if the connection hasn't been established yet.
Also I changed types of the broadcast channels. It's idiomatics to use
chan struct{}to broadcast thanchan bool