This repository was archived by the owner on Jul 21, 2021. It is now read-only.
add support for some of the FourLetter words #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theckman
force-pushed
the
server_stats
branch
2 times, most recently
from
26c2657 to
a5f0f8d
Compare
I have a need for polling the Zookeeper instance with some of the four-letter words. In this PR te following words are implemneted with tests: * srvr * cons * ruok `srvr` get some stats about the server (connections, latencies, leader/follower mode, etc.) `cons` gets detailed information about the individual connections and their sessions `ruok` is actually mostly useless, but specifies whether the server has returned `imok` when prompted with `ruok` I'm not sold on the name of the public API functions, `FLWCons()`, and would happily change them to something better.
| @@ -33,6 +34,54 @@ type Stat struct { | |||
| Pzxid int64 // last modified children | |||
| } | |||
|
|
|||
| // Client is the information for a single Zookeper client and its session. | |||
There was a problem hiding this comment.
Should start with ServerClient instead of Client
Typo on Zookeper
|
Really minor doc issues but otherwise looks great. Thanks! |
|
@samuel wow, those are really lame typos. Sorry about not catching them previously. I've pushed a single commit to address the feedback. Let me know if you need anything else. |
|
No worries. Sorry to be picky. Looks good. |
samuel
added a commit
that referenced
this pull request
Apr 5, 2015
add support for some of the FourLetter words
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a need for polling the Zookeeper instance with some of the four-letter words. In this PR te following words are implemneted with tests:
srvrget some stats about the server (connections, latencies, leader/follower mode, etc.)consgets detailed information about the individual connections and their sessionsruokis actually mostly useless, but specifies whether the server has returnedimokwhen prompted withruokI'm not sold on the name of the public API functions,
FLWCons(), and would happily change them to something better.