This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
Add timeouts around IO calls during authenticate #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @samuel any thoughts? |
|
Overall looks great. It may be better to set the timeout at the start and defer to unset it. This way it limits the total time of the authenticate rather than extending per read/write. Either way it's definitely good to have the timeout. Thanks for the patch. |
|
Ah, didn't think of that approach. I took this path since I wanted to keep it relatively similar to the other examples I saw in |
|
That's cool. Makes sense. |
samuel
added a commit
that referenced
this pull request
Jan 19, 2015
Add timeouts around IO calls during authenticate
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually ended up with a process that was completely blocked trying to
io.ReadFullfrom a connection that may never have responded. It seemed like it might be best to have some form of timeout. I chose to do the* 10to keep the test suite green and allow for slightly longer authenticate calls as they are made only as part of a new connection.