Skip to content
This repository has been archived by the owner on Jul 21, 2021. It is now read-only.

Adding ZK 3.5 reconfig APIs #206

Merged
merged 15 commits into from
Aug 1, 2019
Merged

Conversation

jeffbean
Copy link
Contributor

@jeffbean jeffbean commented Jan 7, 2019

Supersedes #205

  • changes travis tests to handle all versions of the ZK binary distribution.
  • Adding new APIs IncrementalReconfig and Reconfig to support 3.5 reconfig options.

tested on ZK 3.5.4-beta 5 node zk clusters with simple add and remove actions beyond the integration tests included in this PR.

Fixes #204

jeffbean and others added 14 commits December 26, 2018 15:51
more travis tweaks

adding link for pre-build process

goveralls is out for now, also test fixes for older jar strategy

bump them timeouts

adding coveralls but ignore if it fails

Adding back the coveralls env var
ZK 3.5 part1 - Adding test harness in travis and test code for support for zk 3.5 and 3.4
…en connected to a node that is no longer accepting connecitons
 ZK 3.5 part 2 - Adding reconfig and incremental reconfig apis
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 80.685% when pulling 24d8a89 on jeffbean:reconfig-three-five into c4fab1a on samuel:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 80.685% when pulling 24d8a89 on jeffbean:reconfig-three-five into c4fab1a on samuel:master.

@coveralls
Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage increased (+0.5%) to 80.573% when pulling d4027fc on jeffbean:reconfig-three-five into c4fab1a on samuel:master.

@msolo
Copy link

msolo commented Jan 13, 2019

There are a lot of good changes in this PR. I've been integrating improvements to the upstream: https://github.com/z-division/go-zookeeper/wiki

@jeffbean
Copy link
Contributor Author

https://github.com/z-division/go-zookeeper/wiki

Thanks,
I am also working on more fixes and do intend to communicate a plan from my end on how I intend to hard fork this library. It will take a bit of time as I want to ensure folks have some time to respond to my posts and PR before taking any real action, as well as figure out the best course to do so.

If you are looking for more improvements my personal fork master branch has some more testing and bug fixes :D

@samuel
Copy link
Owner

samuel commented Aug 1, 2019

Thanks for the change. I'm not actively maintaining this repo as I haven't used Zookeeper for a very long time, but I'm trying to go through and get some of these changes in just in case there's anyone still relying on this package.

@samuel samuel merged commit 758ce21 into samuel:master Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add the reconfig api for zk > 3.5
4 participants