This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
WithLogger connOption and Conn.logInfo bool #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows setting the logger as the connection is created, rather than racing to call SetLogger while the connection's goroutine might already be logging a successful (or failed) connection. In addition using WithLogger works around the data race between SetLogger and the connection's goroutine. The data race is NOT fixed by this commit. AFAICS doing so is a nontrivial. Every access to conn.logger would need to be atomic.
By default it is enabled for backwards compatability, but by setting logInfo=false you can have silence on stderr when no errors are in fact occurring. This is desireable for commandline tools, where the convention I prefer is that silence indicates success.
|
I'm running across the same race condition and this PR totally fixes it. Any hope of merging it in? |
|
Oh yeah, thanks for the change. |
jeffbean
pushed a commit
to jeffbean/go-zookeeper
that referenced
this pull request
Dec 28, 2018
* add WithLogger connOption This allows setting the logger as the connection is created, rather than racing to call SetLogger while the connection's goroutine might already be logging a successful (or failed) connection. In addition using WithLogger works around the data race between SetLogger and the connection's goroutine. The data race is NOT fixed by this commit. AFAICS doing so is a nontrivial. Every access to conn.logger would need to be atomic. * add Conn.logInfo bool controling informational messages By default it is enabled for backwards compatability, but by setting logInfo=false you can have silence on stderr when no errors are in fact occurring. This is desireable for commandline tools, where the convention I prefer is that silence indicates success.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WithLogger connection option allow setting the logger right away, rather than racing with the connection's goroutine.
WithLogInfo connection option allows silencing the informational messages which otherwise get logged to stderr (by default).