This repository has been archived by the owner on Jul 21, 2021. It is now read-only.
Do not try to create intermitent nodes if they exist during Lock() #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes problems if Authentication is enabled.
vespian
pushed a commit
to d2iq-archive/vault
that referenced
this pull request
Jun 29, 2016
Until samuel/go-zookeeper#127 is merged, we need to temporarily patch vendored package. Basically ZK lib tries to create existing node for which it does not have permissions. Checing if it exists is much safer.
|
@samuel ping? |
|
Looks good, thanks! |
vespian
pushed a commit
to d2iq-archive/vault
that referenced
this pull request
Sep 2, 2016
This update contains two important fixes: samuel/go-zookeeper#127 samuel/go-zookeeper#139 They make vault work if authentication is enabled for ZK backend.
vespian
pushed a commit
to d2iq-archive/mesos-dns
that referenced
this pull request
Sep 6, 2016
This includes many bugfixes, including ones related to authentication: samuel/go-zookeeper#127 samuel/go-zookeeper#139
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes problems if Authentication is enabled.