Fix preprocessing not being applied on Windows #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samualtnorman
approved these changes
Jan 21, 2025
|
ty! |
samualtnorman
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Fix preprocessing not happening for files on Windows * Add Sarah as contributor * Use path.isAbsolute instead of custom function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ifstatement surrounding the preprocessing assumed *nix-like path names, causing files not to preprocess on Windows. This caused the errors in #233 (aside from the bug that was already fixed).