Update market.browse to make all params optional, rather than required.
#171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samualtnorman
requested changes
May 4, 2024
- Simplified Scriptor type for now. - Fixed the rarity type that I broke - Renamed new types to fit convention
samualtnorman
requested changes
May 4, 2024
|
I've just made massive changes to |
samualtnorman
approved these changes
May 4, 2024
|
I resolved the conflicts, are you able to to review the changes I made to your changes. As soon as it looks good to you I'll merge it in. Thanks! |
|
Looks good to me! |
|
your changes will be in the next release and are available now to anyone who runs |
samualtnorman
added a commit
that referenced
this pull request
May 13, 2024
Update `market.browse` to make all params optional, rather than required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
market.browserequires all parameters to be present, which is the inverse of what it should be. This fixes that.