Repository navigation
Remove an assert in cram_index_build. - #2061
Merged
Merged
Conversation
daviesrob
reviewed
Aug 5, 2026
| goto err; | ||
| assert(c->comp_hdr_block->content_type == COMPRESSION_HEADER); | ||
| if (c->comp_hdr_block->content_type != COMPRESSION_HEADER) { | ||
| hts_log_error("Expected a compression header block"); |
Member
There was a problem hiding this comment.
As we've done an htell() just before reading the block, could we print its location in the error message, in a similar way to this example?
Contributor
Author
There was a problem hiding this comment.
We could do, but it'll likely be seen by no-one. The assert has been there since 2013 and the first person to trigger it did it via fuzzing, so we can be pretty sure this is vanishingly rare in the wild, so more informative error messages are probably moot!
Contributor
Author
There was a problem hiding this comment.
Done as requested. I hope the fuzzers feel warm and fuzzy :-)
If we don't have a compression header where expected it now fails in a more graceful manner. Co-Authored-By: Shujie Xiang Fixes samtools#2060 Signed-off-by: James Bonfield <jkb@sanger.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't have a compression header where expected it now fails in a more graceful manner.
Co-Authored-By: Shujie Xiang
Fixes #2060