Fix clang build failure due to --verbosity option handling #2414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarshall
changed the title
|
Looks good to me. Note I tried (I also note our CI tests failed too.) |
|
Apparently the C language's long-standing restrictions around jumping around side-stepping declarations have been relaxed in C23 and GCC 11 supports that as an extension for older language versions too. I'm a bit surprised it's active with |
Prior to C23, declaring a variable after a case label is an error. Introduce a function encapsulating --verbosity parsing to avoid needing a local variable within this option parsing case. Similarly in vcfmerge.c, avoid declaring a variable after a goto label.
jmarshall
force-pushed
the
no-decl-after-label
branch
from
8036764 to
a4d4e59
Compare
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang considers declaring a variable after a case label to be an error. Introduce a function encapsulating
--verbosityparsing to avoid needing a local variable within this option parsing case.Similarly in vcfmerge.c, avoid declaring a variable after a goto label.
(Perhaps this is valid in C11 and GCC is defaulting to that language level…)