Add expect-based PB tests and CI#23
Draft
samth wants to merge 2 commits into
Draft
Conversation
- The CI matrix listed arch arm64 on ubuntu-latest (an x64 runner), which can't install/run an arm64 Racket, so that job always failed. Drop the arch axis; test the x64 'stable' and 'current' versions. - The disassemble-of-a-procedure tests asserted exact machine code, which Racket CS changes between versions, so they could not pass on both 'stable' and 'current'. Check those outputs structurally (non-empty, contains the rbp arity-check) instead. The disassemble-bytes and pb-disassemble cases use fixed bytes and stay exact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-depsTesting
../racket/bin/raco test tests/main.rkthttps://chatgpt.com/codex/tasks/task_e_6851b34fbc38832883a53508b900e888