This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
go sqlgen: binlog testers should compare driver.Values #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to use Valuer to convert a filter value into driver.Value so we run equality check on well-known driver.Value types. This means we need to feed arbitrary filter value into Valuer, and its logic should respect the value type that is passed in.
berfarah
reviewed
Sep 20, 2018
| return f.value.Int(), nil | ||
| case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64: | ||
| return int64(f.value.Uint()), nil |
There was a problem hiding this comment.
^ nice, thanks for catching this
| @@ -88,13 +88,13 @@ func (f Valuer) Value() (driver.Value, error) { | |||
| // Coerce our value into a valid sql/driver.Value (see sql/driver.IsValue). | |||
| // This not only converts base types into their sql counterparts (like int32 -> int64) but also | |||
| // handles custom types (like `type customString string` -> string). | |||
| switch f.Kind { | |||
| switch f.value.Kind() { | |||
| return false | ||
| } | ||
|
|
||
| // Special case: if both driver.Value are slices, compare their byte values. |
|
I will land on staging tomorrow. 🙏 |
changpingc
force-pushed
the
changping/value-filter
branch
from
db14bb6
to
074bd04
Compare
Pull Request Test Coverage Report for Build 1048
💛 - Coveralls |
berfarah
approved these changes
Sep 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently binlog tester does not match int32 filter value against a int64 column, for example. It doesn't support custom type either. This fixes both.