Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Twitch #932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gurupras
Copy link
Contributor

@gurupras gurupras commented May 1, 2018

Add support for all Twitch video types: video, channel and collection

Here's a demo

Sumary of proposed changes

  • Adds new source file twitch.js under plugins
  • Adds the 'twitch' provider

There's a few single-line changes in a bunch of files as part of adding Twitch as a new provider.

Task list

  • Implement progressive enhancement
  • Update readme.md with instructions on how to use Twitch
  • Tested on supported browsers
  • Gulp build completed

@gurupras
Copy link
Contributor Author

gurupras commented May 1, 2018

I need help with progressive enhancement. I'm trying to get a sense of what this is right now, but currently, I have no idea on what it is or how it's implemented in the code.

@friday
Copy link
Collaborator

friday commented May 12, 2018

I need help with progressive enhancement. I'm trying to get a sense of what this is right now, but currently, I have no idea on what it is or how it's implemented in the code.

Progressive enhancement is similar to a "fallback", but instead of checking if the fallback is needed and applying it, you start with the fallback and add the improved behavior later when possible.

For Plyr, this means you add the provider's own embed code inside your custom element.

@MasterProvider
Copy link

@gurupras any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants