Skip to content

Commit

Permalink
chore(build): use pnpm instead of yarn
Browse files Browse the repository at this point in the history
  • Loading branch information
@sampotts
sampotts committed Mar 9, 2023
1 parent 62436d8 commit ed0b901
Show file tree
Hide file tree
Showing 4 changed files with 13,886 additions and 13,676 deletions.
2 changes: 1 addition & 1 deletion .node-version
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.18.1
19.7.0
5 changes: 3 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,12 @@
},
"browserslist": "> 1%",
"scripts": {
"postinstall": "pnpm build",

This comment has been minimized.

Sign in to view

Copy link
@olieady

olieady Mar 9, 2023

This line is causing issues for our install as we don't have pnpm installed.

This comment has been minimized.

Sign in to view

Copy link
@tglazier754

tglazier754 Mar 9, 2023

Trying to work around this has been difficult as well, because I'm using plyr-react which has plyr as a dependency

This comment has been minimized.

Sign in to view

Copy link
@fspoettel

fspoettel Mar 9, 2023

@tglazier754 you can try an override: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides

This comment has been minimized.

Sign in to view

Copy link
@sampotts

sampotts Mar 9, 2023

Author Owner

Apologies for this. I've pushed 3.7.5, which replaces references to pnpm with npm in scripts, which should resolve this issue. Report back if not.

This comment has been minimized.

Sign in to view

Copy link
@sampotts

sampotts Mar 10, 2023

Author Owner

I've now completely removed the postinstall script in 3.7.6
"build": "gulp build",
"lint": "eslint src/js && npm run remark && stylelint **/*.scss",
"lint": "eslint src/js && pnpm remark && stylelint **/*.scss",
"lint:fix": "eslint --fix src/js && stylelint **/*.scss --fix",
"remark": "remark -f --use 'validate-links=repository:\"sampotts/plyr\"' '{,!(node_modules),.?**/}*.md'",
"deploy": "yarn lint && gulp version && gulp build && gulp deploy",
"deploy": "pnpm lint && gulp version && gulp build && gulp deploy",
"format": "prettier --write \"./{src,demo/src}/**/*.{js,scss}\"",
"spellcheck": "cspell \"**/*.{js,md,scss,json}\" --no-must-find-files",
"start": "gulp"
Expand Down
Loading

0 comments on commit ed0b901

Please sign in to comment.