Destination host cannot be * (istio#13222)

* destination host cannot be * * fix test
samos123 · Apr 11, 2019 · cccb01e · cccb01e
1 parent e7f9fd6
commit cccb01e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pilot/pkg/model/validation.go b/pilot/pkg/model/validation.go
@@ -2027,7 +2027,12 @@ func validateDestination(destination *networking.Destination) (errs error) {
 		return
 	}
 
-	errs = appendErrors(errs, ValidateWildcardDomain(destination.Host))
+	host := destination.Host
+	if host == "*" {
+		errs = appendErrors(errs, fmt.Errorf("invalid destintation host %s", host))
+	} else {
+		errs = appendErrors(errs, ValidateWildcardDomain(host))
+	}
 	if destination.Subset != "" {
 		errs = appendErrors(errs, validateSubsetName(destination.Subset))
 	}

diff --git a/pilot/pkg/model/validation_test.go b/pilot/pkg/model/validation_test.go
@@ -2312,7 +2312,7 @@ func TestValidateRouteDestination(t *testing.T) {
 		}}, valid: true},
 		{name: "wildcard", routes: []*networking.RouteDestination{&networking.RouteDestination{
 			Destination: &networking.Destination{Host: "*"},
-		}}, valid: true},
+		}}, valid: false},
 		{name: "bad wildcard", routes: []*networking.RouteDestination{&networking.RouteDestination{
 			Destination: &networking.Destination{Host: "foo.*"},
 		}}, valid: false},