Skip to content

Conversation

RichardHanitio
Copy link
Contributor

Hi, these are the changes I've made.

Here's how it looks :
image
image

Here's how it works :

  1. All
    image

  2. Book Name
    image

  3. Book Author
    image

  4. Book Type
    image

Please kindly let me know if there is any more changes that I need to make, thanks! 😊
One question though, does the "No. of books" depends on the search result? Or is it just displaying the overall number of books on our list?

@samipak458
Copy link
Owner

Hi @RichardHanitio,

Nice work. Yes, it's just displaying overall number of books. If no book available then it will show. I will merge PR after 1st October to that it will count in Hacktoberfest.

@samipak458
Copy link
Owner

In the mean time, can you improve the drop-down styling?

@RichardHanitio
Copy link
Contributor Author

In the mean time, can you improve the drop-down styling?

Ok I'm on it, thanks

@samipak458
Copy link
Owner

Hi,
Kindly sync the fork.

@RichardHanitio
Copy link
Contributor Author

RichardHanitio commented Oct 1, 2022

Hi, I have synced the fork. @samipak458

As for the drop-down styling, here's how it looks now :
image

Honestly, I'm not satisfied with my drop-down options styling, but I can't find a way to change that, and bootstrap's official documentation stated that we cannot modify the options due to browser limitations.

@samipak458
Copy link
Owner

Great work @RichardHanitio. No issues it look good.

@samipak458 samipak458 merged commit be87aae into samipak458:main Oct 2, 2022
@Shashwat0227
Copy link
Contributor

can you go through my pull request it was done before still it is not reviewed once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants