Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References/citations #14

Closed
paulinepalma opened this issue Jun 2, 2020 · 1 comment
Closed

References/citations #14

paulinepalma opened this issue Jun 2, 2020 · 1 comment

Comments

@paulinepalma
Copy link

Paper
The citation for the fda package is Ramsay, Hooker and Grave (2020), not Ramsay & Silverman (1997).

Readme file
In the "Getting help" section, the FDA website triggers a security warning. I recommend indicating the publication date of Ramsay and Silverman book. I believe the first author's name is spelled "Ramsay", not "Ramsey". The link pointing to Allen et al. is incorrect, it links to Eadie & Kapsner-Smith (2011). The acronyms GAMMs and GAMs are used interchangeably, I recommend sticking to one term.
In the References section, Jackson & Sirois (2009) is not mentioned in the text but it is listed here. It is actually in the vignette, so maybe it should be kept here.
Please include a link to the Allen et al. paper.

@samhforbes
Copy link
Owner

Hi @paulinepalma this should be fixed now - I clearly redid the README in too much haste! Thanks for noticing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants