Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use format arg in resources #148

Closed
wants to merge 2 commits into from

Conversation

amureki
Copy link

@amureki amureki commented Aug 22, 2018

Documentation page https://slumber.readthedocs.io/en/v0.6.0/options.html#serializer says
that we can define a certain format for each resource, but this was not taken into an account.
PR adds this behavior and fixes #131.

Documentation page https://slumber.readthedocs.io/en/v0.6.0/options.html#serializer says
that we can define certain format for each resource, but this was not taken into an account.
PR adds this behaviour and fixes samgiles#131.
@coveralls
Copy link

coveralls commented Aug 22, 2018

Coverage Status

Coverage increased (+1.4%) to 88.789% when pulling 85e9031 on Thermondo:format_in_resource into af0f9ef on samgiles:master.

Copy link

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me.

I'd like to have them merged soon since we are facing this issue.

Thanks!

@amureki
Copy link
Author

amureki commented Jan 18, 2019

Hi @samgiles !

Could you bring us some light here? :)

Best,
Rustem

@amureki
Copy link
Author

amureki commented Jan 30, 2023

I am closing this PR for now, as I am no longer working with slumber, and it seems to be unmaintained. Feel free to reopen or reuse provided here code.

@amureki amureki closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format is not taken into account
3 participants