Fix HTML diff highlighting bug for lines containing '\n'
#126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
您好，邮件已收到！
|
|
Nice job @P-SiZK! Thanks for the contribution. |
|
Hi @samg, Appreciate you merging this! I'm looking forward to updating my Thanks, |
|
I just pushed version 3.4.3 which includes this fix. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request fixes a bug in HTML diff output where, if a line contains
'\n'and there are differences in parts of the line other than'\n', the'\n'is incorrectly treated as a newline character and causes unintended line breaks.Details
Diffy::HtmlFormatter, when comparing lines containing'\n', if there are differences outside of the'\n'part,'\n'was interpreted as an actual newline in the HTML output, resulting in the line being split.:htmlformat and does not affect other formats such as:html_simple.'\n'part is displayed as-is in a single line, and only the differing parts are correctly highlighted.This is my first time submitting a pull request to this project.
I would appreciate your review, and if there is anything else I should do or if you have any feedback, please let me know.