Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to health check scripts #3002

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Various fixes to health check scripts #3002

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38be108
health check: use https only when https enabled with non-self signed …
Gaibhne Sep 20, 2024
f9d2c98
health check: remove curl's --location option
Gaibhne Sep 20, 2024
ba429ab
Unset default value for GITLAB_MONITORING_IP_WHITELIST
kkimurak Sep 20, 2024
e5dc2dd
healthcheck: Use IPv4 loopback address instead of localhost
Gaibhne Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
health check: use https only when https enabled with non-self signed … 
…cert
  • Loading branch information
@Gaibhne @kkimurak
Gaibhne authored and kkimurak committed Sep 20, 2024
commit 38be108bc083cee041e616d49fc4f6c4108e1ff0
2 changes: 1 addition & 1 deletion assets/runtime/functions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1855,7 +1855,7 @@ generate_healthcheck_script() {
# configure healthcheck script
## https://docs.gitlab.com/ee/user/admin_area/monitoring/health_check.html
local HEALTHCHECK_PROTOCOL="http"
if [[ "${GITLAB_HTTPS}" == true ]]; then
if [[ "${GITLAB_HTTPS}" == true && "${SSL_SELF_SIGNED}" == false ]]; then
HEALTHCHECK_PROTOCOL="${HEALTHCHECK_PROTOCOL}s"
fi
cat > /usr/local/sbin/healthcheck <<EOF
Expand Down