Resolved. GitLab Pages doesn't work since GitLab v14.0 #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref. sameersbn#2375 As I can see from the error message below, it looks like both `api-secret-key` and `gitlab-server` (or `internal-gitlab-server` ) are required since GitLab v14.0 ``` time="2021-06-28T02:28:34Z" level=fatal msg="could not create domains config source" error="GitLab API URL or API secret has not been provided" ``` https://gitlab.com/gitlab-org/gitlab-pages/-/blob/v1.41.0/internal/source/gitlab/client/client.go#L50-52
achretien
reviewed
Jul 20, 2021
| @@ -4,3 +4,5 @@ auth-redirect-uri={{GITLAB_PAGES_ACCESS_REDIRECT_URI}} | |||
| auth-secret={{GITLAB_PAGES_ACCESS_SECRET}} | |||
| gitlab-server={{GITLAB_PAGES_ACCESS_CONTROL_SERVER}} | |||
| artifacts-server={{GITLAB_PAGES_ARTIFACTS_SERVER_URL}} | |||
| internal-gitlab-server=http://localhost:8181 | |||
| api-secret-key=/home/git/gitlab/.gitlab_pages_secret | |||
There was a problem hiding this comment.
you should use GITLAB_INSTALL_DIR here too match config in assets/runtime/functions
There was a problem hiding this comment.
@achretien Fixed at 73dae28
|
@sameersbn I saw that you updated to 14.0.6 just recently. Can you take a look at this and possibly include this in the next update at least? This affects a production environment I'm maintaining right now and it seems to be affecting all users of the GitLab Pages feature. |
sameersbn
approved these changes
Jul 26, 2021
|
When I manually patch these changes into the v14.1.0 container pages works fine. Thanks for this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. #2375
As I can see from the error message below, it looks like both
api-secret-keyandgitlab-server(orinternal-gitlab-server) are required since GitLab v14.0https://gitlab.com/gitlab-org/gitlab-pages/-/blob/v1.41.0/internal/source/gitlab/client/client.go#L50-52
This patch is actually working on my GitLab