Skip to content

Conversation

@pbe-axelor
Copy link
Contributor

@pbe-axelor pbe-axelor force-pushed the add-smime-email-signing branch 2 times, most recently from e5a4831 to 76bfcdf Compare September 24, 2019 11:05
@pbe-axelor
Copy link
Contributor Author

Rebased onto upstream/master

Copy link
Collaborator

@solidnerd solidnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a better place

email_reply_to: {{GITLAB_EMAIL_REPLY_TO}}
email_subject_suffix: '{{GITLAB_EMAIL_SUBJECT_SUFFIX}}'
email_smime:
#start-email-smime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#start-email-smime

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#start-email-smime moved on top of email_smime

Signed-off-by: Pierre Belloy <p.belloy@axelor.com>
@pbe-axelor pbe-axelor force-pushed the add-smime-email-signing branch from 76bfcdf to 638bba5 Compare September 25, 2019 12:30
Copy link
Collaborator

@solidnerd solidnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@solidnerd solidnerd merged commit 73cb639 into sameersbn:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants