-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add S/MIME Email Signing #2009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S/MIME Email Signing #2009
Conversation
e5a4831 to
76bfcdf
Compare
|
Rebased onto upstream/master |
solidnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a better place
| email_reply_to: {{GITLAB_EMAIL_REPLY_TO}} | ||
| email_subject_suffix: '{{GITLAB_EMAIL_SUBJECT_SUFFIX}}' | ||
| email_smime: | ||
| #start-email-smime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #start-email-smime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#start-email-smime moved on top of email_smime
See https://docs.gitlab.com/ce/administration/smime_signing_email.html Signed-off-by: Pierre Belloy <p.belloy@axelor.com>
Signed-off-by: Pierre Belloy <p.belloy@axelor.com>
76bfcdf to
638bba5
Compare
solidnerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
See https://docs.gitlab.com/ce/administration/smime_signing_email.html
Signed-off-by: Pierre Belloy p.belloy@axelor.com