Skip to content

Rewritten version to optimize requests and use of PHP5 OOP #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

smeinecke
Copy link

No description provided.

@samcleaver
Copy link
Owner

@smeinecke Great looking work, obviously there's a huge amount of changes so will try and find some time this week to review. I had started a rewrite on the dev branch (https://github.com/samcleaver/phpGSB/tree/development/lib) that decoupled the storage side of the system (and added support for Yandex lists) but I still haven't gotten around to the lookup side of things.

Also just a heads up, V3 of the Google Safe Browsing API is now live also. (V2 is deprecated).

@smeinecke
Copy link
Author

Oh, I didn't see that you already rewritten the whole thing 👍 I added yandex support today too :)
2ce4f50

You dev branch looks much better than the old version - I will take a look into this next weekend. It's probably much better to complete that part (and move it to v3). As far as I read into the Changelog of v3 there are not that much changes.

I don't know if yandex also update to v3 like google.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants